Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #52001 to master #56841

Closed

Conversation

alexey-zhukovin
Copy link
Contributor

Port #52001 to master

@alexey-zhukovin alexey-zhukovin requested a review from a team as a code owner April 22, 2020 19:14
@ghost ghost requested review from cmcmarrow and removed request for a team April 22, 2020 19:14
@alexey-zhukovin alexey-zhukovin added Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases and removed Has Testcase labels Apr 22, 2020
waynew and others added 4 commits February 23, 2021 15:55
According to saltstack#52001 we need to add the mod_dir to sys.path if we have
any `utils_dirs`. These tests ensure that happens.
When the minion start clean and there are not utils directory in
the extmods cache, any import from a module to any code inside the
utils directory will fail. A second run of the highstate will fix
this issue, as the utils directories are added into sys.path inside
config/__init__.py, as part of the master and minion startup.

This commit add the utils directories during the synchronization of
the custom modules.

Fixes saltstack#51958
In the original PR it assumed paths would be well-formed. This fix uses
pathlib to split out the paths, which should be much more robust, as
well as ensuring that the mod_dir actually does end with the dir in
utils_dirs.
@waynew waynew removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases has-failing-test labels Feb 23, 2021
@waynew
Copy link
Contributor

waynew commented Feb 23, 2021

I went ahead and added tests to this PR. It should pass across all OSes since I'm using Pathlib, but if not just ping me so I can fix the tests.

@dwoz
Copy link
Contributor

dwoz commented Dec 10, 2023

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.

@dwoz dwoz closed this Dec 10, 2023
@dwoz dwoz added help-wanted Community help is needed to resolve this Abandoned labels Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned help-wanted Community help is needed to resolve this master-port
Projects
Status: PR merged
Development

Successfully merging this pull request may close these issues.

4 participants